hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8096) DatanodeMetrics#blocksReplicated will get incremented early and even for failed transfers
Date Thu, 09 Apr 2015 06:35:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486826#comment-14486826
] 

Hudson commented on HDFS-8096:
------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #7544 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7544/])
HDFS-8096. DatanodeMetrics#blocksReplicated will get incremented early and even for failed
transfers (Contributed by Vinayakumar B) (vinayakumarb: rev 9d8952f97f638ede27e4336b9601507d7bb1de7b)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodeMetrics.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java


> DatanodeMetrics#blocksReplicated will get incremented early and even for failed transfers
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-8096
>                 URL: https://issues.apache.org/jira/browse/HDFS-8096
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8096-01.patch
>
>
> {code}    case DatanodeProtocol.DNA_TRANSFER:
>       // Send a copy of a block to another datanode
>       dn.transferBlocks(bcmd.getBlockPoolId(), bcmd.getBlocks(),
>           bcmd.getTargets(), bcmd.getTargetStorageTypes());
>       dn.metrics.incrBlocksReplicated(bcmd.getBlocks().length);{code}
> In the above code to handle replication transfers from namenode, {{DatanodeMetrics#blocksReplicated}}
is getting incremented early, since the transfer will happen in background. 
> And even failed transfers also getting counted.
> Correct place to increment this counter is {{DataTransfer#run()}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message