hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8076) Code cleanup for DFSInputStream: use offset instead of LocatedBlock when possible
Date Thu, 09 Apr 2015 18:15:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487817#comment-14487817
] 

Hudson commented on HDFS-8076:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/])
HDFS-8076. Code cleanup for DFSInputStream: use offset instead of LocatedBlock when possible.
Contributed by Zhe Zhang. (wang: rev a42bb1cd915abe5dc33eda3c01e8c74c64f35748)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Code cleanup for DFSInputStream: use offset instead of LocatedBlock when possible
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-8076
>                 URL: https://issues.apache.org/jira/browse/HDFS-8076
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>             Fix For: 2.8.0
>
>         Attachments: HDFS-8076-000.patch
>
>
> This JIRA aims to refactor the signatures {{fetchBlockByteRange}} and {{actualGetFromOneDataNode}}.
Instead of taking a {{LocatedBlock}}, I think they should just take the starting offset of
that block, since they'll later call {{getBlockAt}} to refresh the location anyway. I think
we should make it clear so the callers are not surprised if the finally used {{LocatedBlock}}
is not the one they passed in. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message