hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8071) Redundant checkFileProgress() in PART II of getAdditionalBlock()
Date Mon, 06 Apr 2015 23:50:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482219#comment-14482219
] 

Tsz Wo Nicholas Sze commented on HDFS-8071:
-------------------------------------------

Patch looks good.  The readLock() call in checkFileProgress(..) is unnecessary since all the
callers already has the lock.  How about changing it to "assert hasReadLock()"?


> Redundant checkFileProgress() in PART II of getAdditionalBlock()
> ----------------------------------------------------------------
>
>                 Key: HDFS-8071
>                 URL: https://issues.apache.org/jira/browse/HDFS-8071
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.3-alpha
>            Reporter: Konstantin Shvachko
>         Attachments: HDFS-8071-01.patch
>
>
> {{FSN.getAdditionalBlock()}} consists of two parts I and II. Each part calls {{analyzeFileState()}},
which among other things check replication of the penultimate block via {{checkFileProgress()}}.
See details in HDFS-4452.
> Checking file progress in Part II is not necessary, because Part I already assured the
penultimate block is complete. It cannot change to incomplete, unless the file is truncated,
which is not allowed for files under construction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message