hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-8071) Redundant checkFileProgress() in PART II of getAdditionalBlock()
Date Tue, 07 Apr 2015 05:13:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482607#comment-14482607
] 

Hadoop QA commented on HDFS-8071:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12723508/HDFS-8071-02.patch
  against trunk revision 3fb5abf.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10186//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10186//console

This message is automatically generated.

> Redundant checkFileProgress() in PART II of getAdditionalBlock()
> ----------------------------------------------------------------
>
>                 Key: HDFS-8071
>                 URL: https://issues.apache.org/jira/browse/HDFS-8071
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.3-alpha
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: HDFS-8071-01.patch, HDFS-8071-02.patch
>
>
> {{FSN.getAdditionalBlock()}} consists of two parts I and II. Each part calls {{analyzeFileState()}},
which among other things check replication of the penultimate block via {{checkFileProgress()}}.
See details in HDFS-4452.
> Checking file progress in Part II is not necessary, because Part I already assured the
penultimate block is complete. It cannot change to incomplete, unless the file is truncated,
which is not allowed for files under construction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message