hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7969) Erasure coding: NameNode support for lease recovery of striped block groups
Date Mon, 06 Apr 2015 06:42:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14480995#comment-14480995
] 

Yi Liu commented on HDFS-7969:
------------------------------

Hi Zhe, 
The logic in {{initializeBlockRecovery}} to choose primary replica for block recovery should
be the same for striped and contiguous block, so I think you are right to keep them same.
 Your patch looks very good overall, few nits:
*1.* Add description for all interfaces in {{BlockInfoUnderConstruction}}
*2.* Remove the *TODO* comment in {{BlockInfoStripedUnderConstruction#initializeBlockRecovery}}

+1 after addressing.

> Erasure coding: NameNode support for lease recovery of striped block groups
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-7969
>                 URL: https://issues.apache.org/jira/browse/HDFS-7969
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-7969-000.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message