hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7949) WebImageViewer need support file size calculation with striped blocks
Date Thu, 16 Apr 2015 05:41:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497589#comment-14497589
] 

Kai Zheng commented on HDFS-7949:
---------------------------------

The patch looks good. Besides what's commented by Zhe above, ref. below codes, the assertion
isn't clear to me.
{code}
+      assertTrue(
+          "Wrongly computed file size contains striped blocks, file status:"
+              + fileStatus, fileStatus.contains("length\":13107200"));
{code}
bq.can we use a null for the schema here? (when calling {{createErasureCodingZone}})
Yes, null is allowed, and the system default schema will be used.

> WebImageViewer need support file size calculation with striped blocks
> ---------------------------------------------------------------------
>
>                 Key: HDFS-7949
>                 URL: https://issues.apache.org/jira/browse/HDFS-7949
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Hui Zheng
>            Assignee: Rakesh R
>            Priority: Minor
>         Attachments: HDFS-7949-001.patch, HDFS-7949-002.patch, HDFS-7949-003.patch, HDFS-7949-004.patch
>
>
> The file size calculation should be changed when the blocks of the file are striped in
WebImageViewer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message