hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Sasaki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7937) Erasure Coding: INodeFile quota computation unit tests
Date Fri, 10 Apr 2015 02:39:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488791#comment-14488791
] 

Kai Sasaki commented on HDFS-7937:
----------------------------------

[~zhz] Thank you for comment. I have a question. Some assertion values should not be hard-coded?
If these values is calculated based on the same algorithm which is used in the target method,
it does not make sense as test. So I think it might be better to change assertion values every
time when we change the default schema. 

> Erasure Coding: INodeFile quota computation unit tests
> ------------------------------------------------------
>
>                 Key: HDFS-7937
>                 URL: https://issues.apache.org/jira/browse/HDFS-7937
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Sasaki
>            Assignee: Kai Sasaki
>            Priority: Minor
>         Attachments: HDFS-7937.1.patch, HDFS-7937.2.patch, HDFS-7937.3.patch, HDFS-7937.4.patch,
HDFS-7937.5.patch
>
>
> Unit test for [HDFS-7826|https://issues.apache.org/jira/browse/HDFS-7826]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message