hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7889) Subclass DFSOutputStream to support writing striping layout files
Date Fri, 10 Apr 2015 02:30:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488783#comment-14488783
] 

Kai Zheng commented on HDFS-7889:
---------------------------------

4. Ref. below codes: we can change: cellSize + 123 => cellSize * dataBlocks -10. Similar
suggestion in other places.
{code}
+  @Test
+  public void TestFileSmallerThanOneStripe() throws IOException {
+    testOneFile("/SmallerThanOneStripe", cellSize + 123);
+  }
{code}
5. With below codes, can we use {{DFSOutputStream}} instead?
{code}
+      os = fs.create(TestPath);
+      DFSStripedOutputStream dos = (DFSStripedOutputStream) Whitebox.getInternalState(os,
+          "wrappedStream");
{code}
6. {{testOneFile}} is rather lengthy and complex. I remembered [~zhz] suggested we could use
some codes from stripped read work, so we don't need the block reading related codes here.
And we don't need to verify erasure parity recovering logic here to make it simple. It's already
done in the erasure coder tests. Please clean up.

> Subclass DFSOutputStream to support writing striping layout files
> -----------------------------------------------------------------
>
>                 Key: HDFS-7889
>                 URL: https://issues.apache.org/jira/browse/HDFS-7889
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: Li Bo
>         Attachments: HDFS-7889-001.patch, HDFS-7889-002.patch, HDFS-7889-003.patch, HDFS-7889-004.patch,
HDFS-7889-005.patch, HDFS-7889-006.patch, HDFS-7889-007.patch, HDFS-7889-008.patch, HDFS-7889-009.patch,
HDFS-7889-010.patch
>
>
> After HDFS-7888, we can subclass  {{DFSOutputStream}} to support writing striping layout
files. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message