hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7808) Remove obsolete -ns options in in DFSHAAdmin.java
Date Thu, 09 Apr 2015 18:15:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487822#comment-14487822
] 

Hudson commented on HDFS-7808:
------------------------------

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/])
Revert HDFS-7808. (wheat9: rev bd4c99bece56d1671c6f89eff8a529f4e7ac2933)
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdminMiniCluster.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSHAAdmin.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSHAAdmin.java


> Remove obsolete -ns options in in DFSHAAdmin.java
> -------------------------------------------------
>
>                 Key: HDFS-7808
>                 URL: https://issues.apache.org/jira/browse/HDFS-7808
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>            Priority: Minor
>         Attachments: HDFS-7808-1.patch
>
>
> After HDFS-7324 fix following piece of code become unused. It should be removed.
> {code}
>     int i = 0;
>     String cmd = argv[i++];
>     if ("-ns".equals(cmd)) {
>       if (i == argv.length) {
>         errOut.println("Missing nameservice ID");
>         printUsage(errOut);
>         return -1;
>       }
>       nameserviceId = argv[i++];
>       if (i >= argv.length) {
>         errOut.println("Missing command");
>         printUsage(errOut);
>         return -1;
>       }
>       argv = Arrays.copyOfRange(argv, i, argv.length);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message