hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhe Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7578) NFS WRITE and COMMIT responses should always use the channel pipeline
Date Thu, 30 Apr 2015 00:46:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520631#comment-14520631
] 

Zhe Zhang commented on HDFS-7578:
---------------------------------

The patch looks good to me and I don't see an easy way to simplify constructing {{RpcResponse}}.
[~wheat9] if you still remember your idea could you advise?

Luckily the patch still applies. 

> NFS WRITE and COMMIT responses should always use the channel pipeline
> ---------------------------------------------------------------------
>
>                 Key: HDFS-7578
>                 URL: https://issues.apache.org/jira/browse/HDFS-7578
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>    Affects Versions: 2.7.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-7578.001.patch, HDFS-7578.002.patch
>
>
> Write and Commit responses directly write data to the channel instead of propagating
it to the next immediate handler in the channel pipeline. 
> Not following Netty channel pipeline model could be problematic. We don't know whether
it could cause any resource leak or performance issue especially the internal pipeline implementation
keeps changing with newer Netty releases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message