hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7281) Missing block is marked as corrupted block
Date Wed, 29 Apr 2015 05:51:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518771#comment-14518771
] 

Yongjun Zhang commented on HDFS-7281:
-------------------------------------

Hi [~mingma],

Thanks for the new rev and the release notes!   One minor thing, I found three lines touched
by this patch exceed 80 chars:
* Line 852 of BlockManager
* Line 575 and 703 of NamenodeFsck
Really sorry I did not catch them in earlier rounds. +1 after that and jenkins.




> Missing block is marked as corrupted block
> ------------------------------------------
>
>                 Key: HDFS-7281
>                 URL: https://issues.apache.org/jira/browse/HDFS-7281
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>              Labels: supportability
>         Attachments: HDFS-7281-2.patch, HDFS-7281-3.patch, HDFS-7281-4.patch, HDFS-7281-5.patch,
HDFS-7281.patch
>
>
> In the situation where the block lost all its replicas, fsck shows the block is missing
as well as corrupted. Perhaps it is better not to mark the block corrupted in this case. The
reason it is marked as corrupted is numCorruptNodes == numNodes == 0 in the following code.
> {noformat}
> BlockManager
>     final boolean isCorrupt = numCorruptNodes == numNodes;
> {noformat}
> Would like to clarify if it is the intent to mark missing block as corrupted or it is
just a bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message