hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5574) Remove buffer copy in BlockReader.skip
Date Tue, 28 Apr 2015 05:56:08 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516439#comment-14516439
] 

Akira AJISAKA commented on HDFS-5574:
-------------------------------------

Thanks [~decster] for updating the patch.
{code}
<error line="222" column="3" severity="error" message="Method &apos;readAndDiscard&apos;
is not designed for extension - needs to be abstract, final or empty." source="com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck"/>
{code}
Would you add {{final}} to {{FSInputChecker#readAndDiscard}}?
The test failure looks unrelated to the patch.

> Remove buffer copy in BlockReader.skip
> --------------------------------------
>
>                 Key: HDFS-5574
>                 URL: https://issues.apache.org/jira/browse/HDFS-5574
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HDFS-5574.006.patch, HDFS-5574.007.patch, HDFS-5574.v1.patch, HDFS-5574.v2.patch,
HDFS-5574.v3.patch, HDFS-5574.v4.patch, HDFS-5574.v5.patch
>
>
> BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read data to this
buffer, it is not necessary. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message