Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 30 Mar 2015 04:32:53 +0000 (UTC)
From: "Yi Liu (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12786109.1427441867000.65051.1427689973192@Atlassian.JIRA>
In-Reply-To: <JIRA.12786109.1427441867000@Atlassian.JIRA>
References: <JIRA.12786109.1427441867000@Atlassian.JIRA>
 <JIRA.12786109.1427441867660@arcas>
Subject: [jira] [Commented] (HDFS-7997) The first non-existing xattr should
 also throw IOException
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-7997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386177#comment-14386177 ] 

Yi Liu commented on HDFS-7997:
------------------------------

[~sinago], the example you gave is not correct, the xattr should be prefixed with user/trusted/security/system/raw. But the patch looks good.

> The first non-existing xattr should also throw IOException
> ----------------------------------------------------------
>
>                 Key: HDFS-7997
>                 URL: https://issues.apache.org/jira/browse/HDFS-7997
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: zhouyingchao
>            Assignee: zhouyingchao
>            Priority: Minor
>         Attachments: HDFS-7997-001.patch
>
>
> We use the following code snippet to get/set xattrs. However, if there are no xattrs have ever been set, the first getXAttr returns null and the second one just throws exception with message like "At least one of the attributes provided was not found.".  This is not expected, we believe they should behave in the same way - i.e either both getXAttr returns null or both getXAttr throw exception with the message "... not found".  We will provide a patch to make them both throw exception.
> ....
> attrValueNM = fs.getXAttr(path, "nm");
> if (attrValueNM == null) {
>      fs.setXAttr("nm", DEFAULT_VALUE);
> }
> attrValueNN = fs.getXAttr(path, "nn");
> if (attrValueNN == null) {
>     fs.setXAttr("nn", DEFAULT_VALUE);
> }
> ....


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)