Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4C5417B05 for ; Fri, 13 Mar 2015 18:28:39 +0000 (UTC) Received: (qmail 25450 invoked by uid 500); 13 Mar 2015 18:28:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 25391 invoked by uid 500); 13 Mar 2015 18:28:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 25379 invoked by uid 99); 13 Mar 2015 18:28:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Mar 2015 18:28:39 +0000 Date: Fri, 13 Mar 2015 18:28:39 +0000 (UTC) From: "Brandon Li (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7926) NameNode implementation of ClientProtocol.truncate(..) is not idempotent MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360869#comment-14360869 ] Brandon Li commented on HDFS-7926: ---------------------------------- Thank you, [~szetszwo], for the fix. I've committed the patch. > NameNode implementation of ClientProtocol.truncate(..) is not idempotent > ------------------------------------------------------------------------ > > Key: HDFS-7926 > URL: https://issues.apache.org/jira/browse/HDFS-7926 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Attachments: h7926_20150313.patch, h7926_20150313b.patch > > > If dfsclient drops the first response of a truncate RPC call, the retry by retry cache will fail with "DFSClient ... is already the current lease holder". The truncate RPC is annotated as @Idempotent in ClientProtocol but the NameNode implementation is not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)