Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72EA9174FC for ; Thu, 19 Mar 2015 11:18:42 +0000 (UTC) Received: (qmail 37239 invoked by uid 500); 19 Mar 2015 11:17:38 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 37176 invoked by uid 500); 19 Mar 2015 11:17:38 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 37164 invoked by uid 99); 19 Mar 2015 11:17:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 11:17:38 +0000 Date: Thu, 19 Mar 2015 11:17:38 +0000 (UTC) From: "Rakesh R (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7922) ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368878#comment-14368878 ] Rakesh R commented on HDFS-7922: -------------------------------- It looks like test case failures are unrelated to this patch. [~cmccabe] could you please have a look at the new patch. Thanks! > ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors > --------------------------------------------------------------------- > > Key: HDFS-7922 > URL: https://issues.apache.org/jira/browse/HDFS-7922 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Rakesh R > Assignee: Rakesh R > Attachments: 001-HDFS-7922.patch, 002-HDFS-7922.patch > > > ShortCircuitCache has the following executors. It would be good to shutdown these pools during ShortCircuitCache#close to avoid leaks. > {code} > /** > * The executor service that runs the cacheCleaner. > */ > private final ScheduledThreadPoolExecutor cleanerExecutor > = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder(). > setDaemon(true).setNameFormat("ShortCircuitCache_Cleaner"). > build()); > /** > * The executor service that runs the cacheCleaner. > */ > private final ScheduledThreadPoolExecutor releaserExecutor > = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder(). > setDaemon(true).setNameFormat("ShortCircuitCache_SlotReleaser"). > build()); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)