Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61D27172D0 for ; Thu, 19 Mar 2015 15:39:13 +0000 (UTC) Received: (qmail 4738 invoked by uid 500); 19 Mar 2015 15:38:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 4682 invoked by uid 500); 19 Mar 2015 15:38:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 4669 invoked by uid 99); 19 Mar 2015 15:38:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Mar 2015 15:38:38 +0000 Date: Thu, 19 Mar 2015 15:38:38 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7728) Avoid updating quota usage while loading edits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369560#comment-14369560 ] Hadoop QA commented on HDFS-7728: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696286/HDFS-7728.001.patch against trunk revision 522c897. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9980//console This message is automatically generated. > Avoid updating quota usage while loading edits > ---------------------------------------------- > > Key: HDFS-7728 > URL: https://issues.apache.org/jira/browse/HDFS-7728 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Jing Zhao > Assignee: Jing Zhao > Attachments: HDFS-7728.000.patch, HDFS-7728.001.patch > > > Per the discussion [here|https://issues.apache.org/jira/browse/HDFS-7611?focusedCommentId=14292454&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14292454], currently we call {{INode#addSpaceConsumed}} while file/dir/snapshot deletion, even if this is still in the edits loading process. This is unnecessary and can cause issue like HDFS-7611. We should collect quota change and call {{FSDirectory#updateCount}} at the end of the operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)