Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF7C817EAD for ; Mon, 2 Mar 2015 04:07:11 +0000 (UTC) Received: (qmail 95544 invoked by uid 500); 2 Mar 2015 04:07:05 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 95094 invoked by uid 500); 2 Mar 2015 04:07:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 95074 invoked by uid 99); 2 Mar 2015 04:07:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 04:07:05 +0000 Date: Mon, 2 Mar 2015 04:07:05 +0000 (UTC) From: "Takanobu Asanuma (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-7439) Add BlockOpResponseProto's message to DFSClient's exception message MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takanobu Asanuma updated HDFS-7439: ----------------------------------- Status: Patch Available (was: Open) > Add BlockOpResponseProto's message to DFSClient's exception message > ------------------------------------------------------------------- > > Key: HDFS-7439 > URL: https://issues.apache.org/jira/browse/HDFS-7439 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Ming Ma > Assignee: Takanobu Asanuma > Priority: Minor > Attachments: HDFS-7439.1.patch, HDFS-7439.2.patch, HDFS-7439.3.patch > > > When (BlockOpResponseProto#getStatus() != SUCCESS), it helps with debugging if DFSClient can add BlockOpResponseProto's message to the exception message applications will get. For example, instead of > {noformat} > throw new IOException("Got error for OP_READ_BLOCK, self=" > + peer.getLocalAddressString() + ", remote=" > + peer.getRemoteAddressString() + ", for file " + file > + ", for pool " + block.getBlockPoolId() + " block " > + block.getBlockId() + "_" + block.getGenerationStamp()); > {noformat} > It could be, > {noformat} > throw new IOException("Got error for OP_READ_BLOCK, self=" > + peer.getLocalAddressString() + ", remote=" > + peer.getRemoteAddressString() + ", for file " + file > + ", for pool " + block.getBlockPoolId() + " block " > + block.getBlockId() + "_" + block.getGenerationStamp() > + ", status message " + status.getMessage()); > {noformat} > We might want to check out all the references to BlockOpResponseProto in DFSClient. -- This message was sent by Atlassian JIRA (v6.3.4#6332)