Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 911661099F for ; Wed, 4 Mar 2015 21:10:16 +0000 (UTC) Received: (qmail 44927 invoked by uid 500); 4 Mar 2015 21:09:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 44813 invoked by uid 500); 4 Mar 2015 21:09:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 44506 invoked by uid 99); 4 Mar 2015 21:09:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2015 21:09:38 +0000 Date: Wed, 4 Mar 2015 21:09:38 +0000 (UTC) From: "Dongming Liang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-1522) Merge Block.BLOCK_FILE_PREFIX and DataStorage.BLOCK_FILE_PREFIX into one constant MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongming Liang updated HDFS-1522: --------------------------------- Fix Version/s: 3.0.0 Labels: patch (was: ) Target Version/s: 3.0.0 (was: 2.7.0) Affects Version/s: (was: 0.21.0) 3.0.0 Release Note: This merges Block.BLOCK_FILE_PREFIX and DataStorage.BLOCK_FILE_PREFIX into one constant. Hard-coded literals of "blk_" in various files are also updated to use the same constant. Hadoop Flags: Reviewed Status: Patch Available (was: In Progress) Existing test cases are used for testing. The code changes are reviewed by Konstantin Shvachko. > Merge Block.BLOCK_FILE_PREFIX and DataStorage.BLOCK_FILE_PREFIX into one constant > --------------------------------------------------------------------------------- > > Key: HDFS-1522 > URL: https://issues.apache.org/jira/browse/HDFS-1522 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 3.0.0 > Reporter: Konstantin Shvachko > Assignee: Dongming Liang > Labels: patch > Fix For: 3.0.0 > > Attachments: HDFS-1522.002.patch, HDFS-1522.patch > > > Two semantically identical constant {{Block.BLOCK_FILE_PREFIX}} and {{DataStorage.BLOCK_FILE_PREFIX}} should merged into one. Should be defined in {{Block}}, imo. > Also use cases of "blok_", like in {{DirectoryScanner}} should be replaced by the this constant. -- This message was sent by Atlassian JIRA (v6.3.4#6332)