hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7978) Add LOG.isDebugEnabled() guard for some LOG.debug(..)
Date Tue, 24 Mar 2015 16:53:54 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378147#comment-14378147
] 

Tsuyoshi Ozawa commented on HDFS-7978:
--------------------------------------

[~andrew.wang] [~walter.k.su] it sounds reasonable to me to avoid concatenating with LOG.isDebugEnabled
guard too. 

> Add LOG.isDebugEnabled() guard for some LOG.debug(..)
> -----------------------------------------------------
>
>                 Key: HDFS-7978
>                 URL: https://issues.apache.org/jira/browse/HDFS-7978
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Walter Su
>            Assignee: Walter Su
>         Attachments: HDFS-7978.001.patch
>
>
> {{isDebugEnabled()}} is optional. But when there are :
> 1. lots of concatenating Strings
> 2. complicated function calls
> in the arguments, {{LOG.debug(..)}} should be guarded with {{LOG.isDebugEnabled()}} to
avoid unnecessary arguments evaluation and impove performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message