hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7944) Minor cleanup of BlockPoolManager#getAllNamenodeThreads
Date Tue, 31 Mar 2015 04:21:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387948#comment-14387948
] 

Hadoop QA commented on HDFS-7944:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12708275/HDFS-7944.02.patch
  against trunk revision 1a495fb.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10120//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10120//console

This message is automatically generated.

> Minor cleanup of BlockPoolManager#getAllNamenodeThreads
> -------------------------------------------------------
>
>                 Key: HDFS-7944
>                 URL: https://issues.apache.org/jira/browse/HDFS-7944
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Minor
>         Attachments: HDFS-7944.01.patch, HDFS-7944.02.patch
>
>
> {{BlockPoolManager#getAllNamenodeThreads}} can avoid unnecessary list to array conversion
and vice versa by returning an unmodifiable list.
> Since NN addition/removal is relatively rare we can just use a {{CopyOnWriteArrayList}}
for concurrency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message