hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7922) ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors
Date Thu, 12 Mar 2015 23:12:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359591#comment-14359591
] 

Hadoop QA commented on HDFS-7922:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12704228/001-HDFS-7922.patch
  against trunk revision 6dae6d1.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitCache
                  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
                  org.apache.hadoop.hdfs.TestAppendSnapshotTruncate
                  org.apache.hadoop.hdfs.server.namenode.TestFileTruncate

                                      The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9855//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9855//console

This message is automatically generated.

> ShortCircuitCache#close is not releasing ScheduledThreadPoolExecutors
> ---------------------------------------------------------------------
>
>                 Key: HDFS-7922
>                 URL: https://issues.apache.org/jira/browse/HDFS-7922
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: 001-HDFS-7922.patch
>
>
> ShortCircuitCache has the following executors. It would be good to shutdown these pools
during ShortCircuitCache#close to avoid leaks.
> {code}
>   /**
>    * The executor service that runs the cacheCleaner.
>    */
>   private final ScheduledThreadPoolExecutor cleanerExecutor
>   = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
>           setDaemon(true).setNameFormat("ShortCircuitCache_Cleaner").
>           build());
>   /**
>    * The executor service that runs the cacheCleaner.
>    */
>   private final ScheduledThreadPoolExecutor releaserExecutor
>       = new ScheduledThreadPoolExecutor(1, new ThreadFactoryBuilder().
>           setDaemon(true).setNameFormat("ShortCircuitCache_SlotReleaser").
>           build());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message