hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7854) Separate class DataStreamer out of DFSOutputStream
Date Mon, 23 Mar 2015 21:53:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376723#comment-14376723
] 

Jing Zhao commented on HDFS-7854:
---------------------------------

Thanks Bo and Zhe for working on this! The 009 patch looks pretty good to me. Only some nits:
# With the HdfsFileStatus passed into DataStreamer, we may no longer need to define {{blockSize}}
and {{fileId}} in {{DataStreamer}}. We can directly call {{stat#getXXX}}.
# There is a tab in {{DataStreamer#run}}
# In {{DFSOutputStream#flushOrSync}}, there is a redundant ";"
{code}
toWaitFor = streamer.getLastQueuedSeqno();;
{code}
# We can move static methods to the beginning of DataStreamer.java
# We should remove the item for {{DFSOutputStream$DataStreamer$ResponseProcessor}} from findbugsExcludeFile:
# It may be more clear to move the {{adjustPacketChunkSize}} and {{streamer.setPipelineInConstruction}}
call into the first "if" section: these are all the actions for appending to the last block.
# {{DFSOutputStream#completeFile}}'s change is unnecessary?
# {{DFSOutputStream#createSocketForPipeline}} can be removed

> Separate class DataStreamer out of DFSOutputStream
> --------------------------------------------------
>
>                 Key: HDFS-7854
>                 URL: https://issues.apache.org/jira/browse/HDFS-7854
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: Li Bo
>         Attachments: HDFS-7854-001.patch, HDFS-7854-002.patch, HDFS-7854-003.patch, HDFS-7854-004-duplicate.patch,
HDFS-7854-004-duplicate2.patch, HDFS-7854-004-duplicate3.patch, HDFS-7854-004.patch, HDFS-7854-005.patch,
HDFS-7854-006.patch, HDFS-7854-007.patch, HDFS-7854-008.patch, HDFS-7854-009.patch
>
>
> This sub task separate DataStreamer from DFSOutputStream. New DataStreamer will accept
packets and write them to remote datanodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message