hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7844) Create an off-heap hash table implementation
Date Tue, 10 Mar 2015 13:07:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354853#comment-14354853

Yi Liu commented on HDFS-7844:

Thanks Colin for updating the patch. 

I'm going to commit v4 and file the follow-up for test improvements.

>> (maintainCompactness) looks brief, but I think it's not effective. putInternal needs
probing if the slot was not in the right place, so it's not effictive.
putInternal does do probing, though. Maybe I'm missing something but I think this should work.
Also, I can tell from the log messages that maintainCompactness is getting some testing. I
didn't like the original implementation because it was duplicating a lot of code from putInternal.
I'm OK with your new approach :)
Sorry that I use a wrong word. I should use *efficient* instead of *effective*, I agreed it
should work, I was thinking the new approach did additional probe if the slot was not in the
right place, so the original implementation is a bit more efficient. But I think it's not
a big deal.

> Create an off-heap hash table implementation
> --------------------------------------------
>                 Key: HDFS-7844
>                 URL: https://issues.apache.org/jira/browse/HDFS-7844
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7836
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7844-scl.001.patch, HDFS-7844-scl.002.patch, HDFS-7844-scl.003.patch,
> Create an off-heap hash table implementation.

This message was sent by Atlassian JIRA

View raw message