hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takanobu Asanuma (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-7829) Code clean up for LocatedBlock
Date Thu, 05 Mar 2015 09:24:38 GMT

     [ https://issues.apache.org/jira/browse/HDFS-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Takanobu Asanuma updated HDFS-7829:
-----------------------------------
    Attachment: HDFS-7829.1.patch

I implemented Builder pattern in LocatedBlock and submitted the patch. If there is no problem,
I'd like to confirm the following next steps.

1. Fixing all source codes calling constructor of LocatedBlock to use builder.
2. Removing multiple constructors.
3. Setting data fields to final.

How does that look? Thank you.

> Code clean up for LocatedBlock
> ------------------------------
>
>                 Key: HDFS-7829
>                 URL: https://issues.apache.org/jira/browse/HDFS-7829
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Jing Zhao
>            Assignee: Takanobu Asanuma
>            Priority: Minor
>         Attachments: HDFS-7829.1.patch
>
>
> We can do some code cleanup for {{LocatedBlock}}, including:
> # Using a simple Builder pattern to avoid multiple constructors
> # Setting data fields like {{corrupt}} and {{offset}} to final



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message