hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takanobu Asanuma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7829) Code clean up for LocatedBlock
Date Tue, 10 Mar 2015 08:04:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354498#comment-14354498
] 

Takanobu Asanuma commented on HDFS-7829:
----------------------------------------

Thanks for your review, Jin. The constructor in RecoveringBlock calls super constructor with
four parameters. So I implemented builder pattern in RecoveringBlock to remove all public
constructor in LocatedBlock. But it may be better to remain constructor with four parameters
in LocatedBlock. Although I implemented builder in RecoveringBlock, I will fix my patch if
there is better idea.

> Code clean up for LocatedBlock
> ------------------------------
>
>                 Key: HDFS-7829
>                 URL: https://issues.apache.org/jira/browse/HDFS-7829
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Jing Zhao
>            Assignee: Takanobu Asanuma
>            Priority: Minor
>         Attachments: HDFS-7829.1.patch, HDFS-7829.2.patch
>
>
> We can do some code cleanup for {{LocatedBlock}}, including:
> # Using a simple Builder pattern to avoid multiple constructors
> # Setting data fields like {{corrupt}} and {{offset}} to final



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message