hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HDFS-7645) Rolling upgrade is restoring blocks from trash multiple times
Date Fri, 13 Mar 2015 18:05:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360820#comment-14360820
] 

Arpit Agarwal edited comment on HDFS-7645 at 3/13/15 6:04 PM:
--------------------------------------------------------------

Hi [~ogikei], did you get a chance to read the comments I added for the v1 patch?

Could you please describe what your patch is attempting to do? Is it your intention to get
rid of trash completely, because removing enableTrash will have that effect.

bq. This is exactly does the job when the datanode is rolled back. But problem is (as from
the beginning) entire cluster ( including those DNs who have not yet upgraded) must be restarted
with '-rollback' option to restore.
[~vinayrpet], we already require the cluster to be stopped and DNs to be restarted with {{-rollback}}
to proceed with the rollback so we can support DN layout upgrades. Not sure I understand what
you meant.

bq. I think you want clearTrash() to be called when a rolling upgrade is finalized. That is
if inProgress is not true, clear all trash. For regular or downgrade start-ups, if the rolling
upgrade is already aborted/finallized, the trash will get cleared once the datanode registers
with the namenode. So we don't have to anything special on start-up.
Clearing trash is probably the right thing to do but there is a caveat. DNs do not get a 'finalize
rolling upgrade' indication. DNs look for {{RollingUpgradeStatus}} in the heartbeat response.
If it is absent then DNs infer that the rolling upgrade is finalized. If the administrator
attempts to do a rollback without stopping all DNs first then clearing trash will cause data
loss. That's a risk of clearing vs doing restore. Currently with restore there is no such
risk since NNs will either keep or delete the blocks appropriately.


was (Author: arpitagarwal):
Hi [~ogikei], did you get a chance to read the comments I added for the v1 patch?

Could you please describe what your patch is attempting to do? Is it your intention to get
rid of trash completely, because removing enableTrash will have that effect.

bq. This is exactly does the job when the datanode is rolled back. But problem is (as from
the beginning) entire cluster ( including those DNs who have not yet upgraded) must be restarted
with '-rollback' option to restore.
[~vinayrpet], we already require the cluster to be stopped and DNs to be restarted with {{-rollback}}
to proceed with the rollback so we can support DN layout upgrades. Not sure I understand your
comment.

bq. I think you want clearTrash() to be called when a rolling upgrade is finalized. That is
if inProgress is not true, clear all trash. For regular or downgrade start-ups, if the rolling
upgrade is already aborted/finallized, the trash will get cleared once the datanode registers
with the namenode. So we don't have to anything special on start-up.
Clearing trash is probably the right thing to do but there is a caveat. DNs do not get a 'finalize
rolling upgrade' indication. DNs look for {{RollingUpgradeStatus}} in the heartbeat response.
If it is absent then DNs infer that the rolling upgrade is finalized. If the administrator
attempts to do a rollback without stopping all DNs first then clearing trash will cause data
loss. That's a risk of clearing vs doing restore. Currently with restore there is no such
risk since NNs will either keep or delete the blocks appropriately.

> Rolling upgrade is restoring blocks from trash multiple times
> -------------------------------------------------------------
>
>                 Key: HDFS-7645
>                 URL: https://issues.apache.org/jira/browse/HDFS-7645
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.6.0
>            Reporter: Nathan Roberts
>            Assignee: Keisuke Ogiwara
>         Attachments: HDFS-7645.01.patch, HDFS-7645.02.patch, HDFS-7645.03.patch
>
>
> When performing an HDFS rolling upgrade, the trash directory is getting restored twice
when under normal circumstances it shouldn't need to be restored at all. iiuc, the only time
these blocks should be restored is if we need to rollback a rolling upgrade. 
> On a busy cluster, this can cause significant and unnecessary block churn both on the
datanodes, and more importantly in the namenode.
> The two times this happens are:
> 1) restart of DN onto new software
> {code}
>   private void doTransition(DataNode datanode, StorageDirectory sd,
>       NamespaceInfo nsInfo, StartupOption startOpt) throws IOException {
>     if (startOpt == StartupOption.ROLLBACK && sd.getPreviousDir().exists()) {
>       Preconditions.checkState(!getTrashRootDir(sd).exists(),
>           sd.getPreviousDir() + " and " + getTrashRootDir(sd) + " should not " +
>           " both be present.");
>       doRollback(sd, nsInfo); // rollback if applicable
>     } else {
>       // Restore all the files in the trash. The restored files are retained
>       // during rolling upgrade rollback. They are deleted during rolling
>       // upgrade downgrade.
>       int restored = restoreBlockFilesFromTrash(getTrashRootDir(sd));
>       LOG.info("Restored " + restored + " block files from trash.");
>     }
> {code}
> 2) When heartbeat response no longer indicates a rollingupgrade is in progress
> {code}
>   /**
>    * Signal the current rolling upgrade status as indicated by the NN.
>    * @param inProgress true if a rolling upgrade is in progress
>    */
>   void signalRollingUpgrade(boolean inProgress) throws IOException {
>     String bpid = getBlockPoolId();
>     if (inProgress) {
>       dn.getFSDataset().enableTrash(bpid);
>       dn.getFSDataset().setRollingUpgradeMarker(bpid);
>     } else {
>       dn.getFSDataset().restoreTrash(bpid);
>       dn.getFSDataset().clearRollingUpgradeMarker(bpid);
>     }
>   }
> {code}
> HDFS-6800 and HDFS-6981 were modifying this behavior making it not completely clear whether
this is somehow intentional. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message