hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kihwal Lee (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7434) DatanodeID hashCode should not be mutable
Date Wed, 04 Mar 2015 23:19:40 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347762#comment-14347762
] 

Kihwal Lee commented on HDFS-7434:
----------------------------------

+1 looks good to me.

> DatanodeID hashCode should not be mutable
> -----------------------------------------
>
>                 Key: HDFS-7434
>                 URL: https://issues.apache.org/jira/browse/HDFS-7434
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-7434.patch
>
>
> Mutable hash codes may lead to orphaned instances in a collection.  Instances must always
be removed prior to modification of hash code values, and re-inserted.  Although current code
appears to do this, the mutable hash code is a landmine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message