hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7434) DatanodeID hashCode should not be mutable
Date Thu, 05 Mar 2015 14:31:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348779#comment-14348779
] 

Hudson commented on HDFS-7434:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk #2055 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2055/])
HDFS-7434. DatanodeID hashCode should not be mutable. Contributed by Daryn Sharp. (kihwal:
rev 722b4794693d8bad1dee0ca5c2f99030a08402f9)
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestComputeInvalidateWork.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockManager.java
* hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeProtocolRetryPolicy.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeRegistration.java
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java


> DatanodeID hashCode should not be mutable
> -----------------------------------------
>
>                 Key: HDFS-7434
>                 URL: https://issues.apache.org/jira/browse/HDFS-7434
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 2.7.0
>
>         Attachments: HDFS-7434.patch
>
>
> Mutable hash codes may lead to orphaned instances in a collection.  Instances must always
be removed prior to modification of hash code values, and re-inserted.  Although current code
appears to do this, the mutable hash code is a landmine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message