hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7054) Make DFSOutputStream tracing more fine-grained
Date Wed, 18 Mar 2015 19:13:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367693#comment-14367693

Colin Patrick McCabe commented on HDFS-7054:

bq. When would parents come back empty?

If tracing was disabled, parents would be empty.  Or any time when none of the requests were

bq. In hsync, the no arg method calls the method with an Enum and both get scope and close
when done. Could be a double-close. That is ok? We do it in both methods because either could
be called?

Oops!  This isn't quite a double close, but it would result in two trace spans for the same
thing (one nested inside the other).  Let me fix that...

bq. A test for the manipulation in getTraceParents?

Let me see if I can add a unit test...

> Make DFSOutputStream tracing more fine-grained
> ----------------------------------------------
>                 Key: HDFS-7054
>                 URL: https://issues.apache.org/jira/browse/HDFS-7054
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7054.001.patch, HDFS-7054.002.patch

This message was sent by Atlassian JIRA

View raw message