hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-6585) INodesInPath.resolve is called multiple times in FSNamesystem.setPermission
Date Sat, 14 Mar 2015 00:21:39 GMT

    [ https://issues.apache.org/jira/browse/HDFS-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361382#comment-14361382
] 

Hadoop QA commented on HDFS-6585:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12651837/patch_f15b7d505f12213f1ee9fb5ddb4bdaa64f9f623d.txt
  against trunk revision 6fdef76.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9885//console

This message is automatically generated.

> INodesInPath.resolve is called multiple times in FSNamesystem.setPermission
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-6585
>                 URL: https://issues.apache.org/jira/browse/HDFS-6585
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Zhilei Xu
>            Assignee: Zhilei Xu
>         Attachments: patch_ab60af58e03b323dd4b18d32c4def1f008b98822.txt, patch_f15b7d505f12213f1ee9fb5ddb4bdaa64f9f623d.txt
>
>
> Most of the APIs (both internal and external) in FSNamesystem calls INodesInPath.resolve()
to get the list of INodes corresponding to a file path. Usually one API will call resolve()
multiple times and that's a waste of time.
> This issue particularly refers to FSNamesystem.setPermission, which calls resolve() twice
indirectly: one from checkOwner(), another from dir.setPermission().
> Should save the result of resolve(), and use it whenever possible throughout the lifetime
of an API call, instead of making new resolve() calls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message