hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yongjun Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5215) dfs.datanode.du.reserved is not taking effect as it's not considered while getting the available space
Date Mon, 30 Mar 2015 18:07:54 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387098#comment-14387098
] 

Yongjun Zhang commented on HDFS-5215:
-------------------------------------

HI [~brahmareddy],

Thanks for updating the patch. It looks good to me, some comments:

#  add javadoc for {{getAvailable()}}, like how {{getCapacity()}} method does.
#  add comment to, the freeSpace is now excluding reserved after this patch: 
{code}
private static class VolumeInfo {
    final String directory;
    final long usedSpace;
    final long freeSpace;
    final long reservedSpace;
{code}
#  if possible, can we add a test or modify TestNamenodeCapacityReport#testVolumeSize to see
the impact of this change?

Thanks.


> dfs.datanode.du.reserved is not taking effect as it's not considered while getting the
available space
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-5215
>                 URL: https://issues.apache.org/jira/browse/HDFS-5215
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-5215-002.patch, HDFS-5215.patch
>
>
> {code}public long getAvailable() throws IOException {
>     long remaining = getCapacity()-getDfsUsed();
>     long available = usage.getAvailable();
>     if (remaining > available) {
>       remaining = available;
>     }
>     return (remaining > 0) ? remaining : 0;
>   } 
> {code}
> Here we are not considering the reserved space while getting the Available Space.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message