Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DFCA117459 for ; Tue, 24 Feb 2015 08:00:38 +0000 (UTC) Received: (qmail 64163 invoked by uid 500); 24 Feb 2015 08:00:38 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 64014 invoked by uid 500); 24 Feb 2015 08:00:38 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 63768 invoked by uid 99); 24 Feb 2015 08:00:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2015 08:00:38 +0000 Date: Tue, 24 Feb 2015 08:00:38 +0000 (UTC) From: "Konstantin Shvachko (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-7831) Fix the starting index of the loop in FileDiffList.findEarlierSnapshotBlocks(). MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shvachko updated HDFS-7831: -------------------------------------- Attachment: HDFS-7831-01.patch Fixed the starting index for the loop. Also we do not need to check that {{i < diffs.size()}}, because now it always is. This should be treated as an optimization, so there are no additional test cases. > Fix the starting index of the loop in FileDiffList.findEarlierSnapshotBlocks(). > ------------------------------------------------------------------------------- > > Key: HDFS-7831 > URL: https://issues.apache.org/jira/browse/HDFS-7831 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Konstantin Shvachko > Attachments: HDFS-7831-01.patch > > > Currently the loop in {{FileDiffList.findEarlierSnapshotBlocks()}} starts from {{insertPoint + 1}}. It should start from {{insertPoint - 1}}. As noted in [Jing's comment|https://issues.apache.org/jira/browse/HDFS-7056?focusedCommentId=14333864&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14333864] -- This message was sent by Atlassian JIRA (v6.3.4#6332)