Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4369717534 for ; Tue, 10 Feb 2015 04:15:36 +0000 (UTC) Received: (qmail 63809 invoked by uid 500); 10 Feb 2015 04:15:35 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 63539 invoked by uid 500); 10 Feb 2015 04:15:35 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 63429 invoked by uid 99); 10 Feb 2015 04:15:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Feb 2015 04:15:35 +0000 Date: Tue, 10 Feb 2015 04:15:35 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7744) Fix potential NPE in DFSInputStream after setDropBehind or setReadahead is called MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313516#comment-14313516 ] Colin Patrick McCabe commented on HDFS-7744: -------------------------------------------- Findbugs warning is unrelated (it is about BackupImage, which wasn't changed in this patch). > Fix potential NPE in DFSInputStream after setDropBehind or setReadahead is called > --------------------------------------------------------------------------------- > > Key: HDFS-7744 > URL: https://issues.apache.org/jira/browse/HDFS-7744 > Project: Hadoop HDFS > Issue Type: Bug > Components: dfsclient > Affects Versions: 2.6.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HDFS-7744.001.patch, HDFS-7744.002.patch > > > Fix a potential NPE in DFSInputStream after setDropBehind or setReadahead is called. These functions clear the {{blockReader}}, but don't set {{blockEnd}} to -1, which could lead to {{DFSInputStream#seek}} attempting to derference {{blockReader}} even though it is {{null}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)