Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6913F17E8B for ; Fri, 6 Feb 2015 02:30:35 +0000 (UTC) Received: (qmail 10366 invoked by uid 500); 6 Feb 2015 02:30:35 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 10325 invoked by uid 500); 6 Feb 2015 02:30:34 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 10313 invoked by uid 99); 6 Feb 2015 02:30:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Feb 2015 02:30:34 +0000 Date: Fri, 6 Feb 2015 02:30:34 +0000 (UTC) From: "Colin Patrick McCabe (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7741) Remove unnecessary synchronized in FSDataInputStream and HdfsDataInputStream MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308484#comment-14308484 ] Colin Patrick McCabe commented on HDFS-7741: -------------------------------------------- +1 pending jenkins. The locking on the wrapper streams adds nothing here, since we lock inside DFSInputStream. Thanks, Yi. > Remove unnecessary synchronized in FSDataInputStream and HdfsDataInputStream > ---------------------------------------------------------------------------- > > Key: HDFS-7741 > URL: https://issues.apache.org/jira/browse/HDFS-7741 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Yi Liu > Assignee: Yi Liu > Priority: Minor > Attachments: HDFS-7741.001.patch > > > The {{synchronized}} for {{HdfsDataInputStream#getAllBlocks}} and {{FSDataInputStream#seek}} are unnecessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)