Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC88617AC4 for ; Fri, 6 Feb 2015 00:17:35 +0000 (UTC) Received: (qmail 16736 invoked by uid 500); 6 Feb 2015 00:17:35 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 16676 invoked by uid 500); 6 Feb 2015 00:17:35 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 16664 invoked by uid 99); 6 Feb 2015 00:17:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Feb 2015 00:17:35 +0000 Date: Fri, 6 Feb 2015 00:17:35 +0000 (UTC) From: "Tsz Wo Nicholas Sze (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-7738) Add more negative tests for truncate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308317#comment-14308317 ] Tsz Wo Nicholas Sze commented on HDFS-7738: ------------------------------------------- h7738_20150205.patch: - adds RecoverLeaseOp; - uses assertEquals as suggested - changes DFSTestUtil.getFileSystemAs to not throwing InterruptedException - moves safemode test to TestSafeMode - adds truncate tests with HA Konstantin, thanks for the review. I incorporated all your comments except #3 since I like to reuse the variable names. Logically, they are separated test cases. For the HA test, it cannot truncate for 5 times unless truncating at block boundaries since the file is not ready (it is under recovery.) > Add more negative tests for truncate > ------------------------------------ > > Key: HDFS-7738 > URL: https://issues.apache.org/jira/browse/HDFS-7738 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Priority: Minor > Fix For: 2.7.0 > > Attachments: h7738_20150204.patch, h7738_20150205.patch > > > The following are negative test cases for truncate. > - new length > old length > - truncating a directory > - truncating a non-existing file > - truncating a file without write permission > - truncating a file opened for append > - truncating a file in safemode -- This message was sent by Atlassian JIRA (v6.3.4#6332)