Return-Path: 
 <hdfs-issues-return-108427-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4E0FC178DC
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Sat,  7 Feb 2015 04:57:35 +0000 (UTC)
Received: (qmail 31078 invoked by uid 500); 7 Feb 2015 04:57:35 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 31020 invoked by uid 500); 7 Feb 2015 04:57:35 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 30997 invoked by uid 99); 7 Feb 2015 04:57:35 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Feb 2015 04:57:35 +0000
Date: Sat, 7 Feb 2015 04:57:34 +0000 (UTC)
From: "Akira AJISAKA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12618723.1354621146000.289753.1423285054881@Atlassian.JIRA>
In-Reply-To: <JIRA.12618723.1354621146000@Atlassian.JIRA>
References: <JIRA.12618723.1354621146000@Atlassian.JIRA>
 <JIRA.12618723.1354621146520@arcas>
Subject: [jira] [Commented] (HDFS-4265) BKJM doesn't take advantage of
 speculative reads
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310554#comment-14310554 ] 

Akira AJISAKA commented on HDFS-4265:
-------------------------------------

Here are some trivial comments:
* Some inserted lines are over 80 characters.
* There is a trailing whitespace.
{code}
+   * Sleep a bookie until I count down the latch
+   * 
+   * @param latch
{code}
* Would you please remove the initial capacity of the list? It's a little confusing.
{code}
+  private static List<BookieServer> bks = new ArrayList<BookieServer>(4);
{code}

I'm +1 after these are addressed.

> BKJM doesn't take advantage of speculative reads
> ------------------------------------------------
>
>                 Key: HDFS-4265
>                 URL: https://issues.apache.org/jira/browse/HDFS-4265
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 2.2.0
>            Reporter: Ivan Kelly
>            Assignee: Rakesh R
>         Attachments: 0005-HDFS-4265.patch, 0006-HDFS-4265.patch, 0007-HDFS-4265.patch, 001-HDFS-4265.patch, 002-HDFS-4265.patch, 003-HDFS-4265.patch, 004-HDFS-4265.patch
>
>
> BookKeeperEditLogInputStream reads entry at a time, so it doesn't take advantage of the speculative read mechanism introduced by BOOKKEEPER-336.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)