hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7790) Do not create optional fields in DFSInputStream unless they are needed
Date Thu, 12 Feb 2015 22:22:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319122#comment-14319122
] 

Aaron T. Myers commented on HDFS-7790:
--------------------------------------

Patch looks good to me, and I'm confident that the test failures are unrelated. +1.

> Do not create optional fields in DFSInputStream unless they are needed
> ----------------------------------------------------------------------
>
>                 Key: HDFS-7790
>                 URL: https://issues.apache.org/jira/browse/HDFS-7790
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: dfsclient
>    Affects Versions: 2.3.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-7790.001.patch
>
>
> {{DFSInputStream#oneByteBuffer}} and {{DFSInputStream#extendedReadBuffers}} are only
used some of the time, and they are always used under the positional lock.  Let's create them
on demand to save memory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message