hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7775) Refactor: Consistent method signature for QuotaCounts and DirectoryWithQuotaFeature class
Date Sat, 14 Feb 2015 04:56:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321233#comment-14321233

Arpit Agarwal commented on HDFS-7775:

+1 for the patch. I will commit it shortly.

> Refactor: Consistent method signature for QuotaCounts and DirectoryWithQuotaFeature class
> -----------------------------------------------------------------------------------------
>                 Key: HDFS-7775
>                 URL: https://issues.apache.org/jira/browse/HDFS-7775
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>            Priority: Minor
>         Attachments: HDFS-7775.0.patch
> This is based on the code review feedback from [~arpitagarwal] on HDFS-7723. We decide
to put the refactoring/renaming work in a separate JIRA to avoid further increasing the size
of current patch for HDFS-7723. Below is the initial refactoring to-do list.
> * QuotaCounts: typeSpaces and typeCounts are used interchangeably. We should probably
name them consistently.
would be easier to understand. Comments like @return the namespace and diskspace consumed
can also be edited to use storage space instead of diskspace. 
> * Add Javadocs to FsImageFormat.java on why storage type quota for FSImageFormat.java.
"We don't have quota by storage type record in legacy fsimages, which is handled in this FSImageFormat
class (used by legacy_oiv only). The current fsimage processing is done in the protobuf based
class FSImageFormatProtobuf, which is updated with typeCounts by HDFS-7723."

This message was sent by Atlassian JIRA

View raw message