hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7775) Refactor: Consistent method signature for QuotaCounts and DirectoryWithQuotaFeature class
Date Sat, 14 Feb 2015 02:47:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321183#comment-14321183
] 

Hadoop QA commented on HDFS-7775:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12698847/HDFS-7775.0.patch
  against trunk revision 0d521e3.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9578//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9578//console

This message is automatically generated.

> Refactor: Consistent method signature for QuotaCounts and DirectoryWithQuotaFeature class
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-7775
>                 URL: https://issues.apache.org/jira/browse/HDFS-7775
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>            Priority: Minor
>         Attachments: HDFS-7775.0.patch
>
>
> This is based on the code review feedback from [~arpitagarwal] on HDFS-7723. We decide
to put the refactoring/renaming work in a separate JIRA to avoid further increasing the size
of current patch for HDFS-7723. Below is the initial refactoring to-do list.
> * QuotaCounts: typeSpaces and typeCounts are used interchangeably. We should probably
name them consistently.
> * You renamed DEFAULT_DISKSPACE_QUOTA to DEFAULT_SPACE_QUOTA. DEFAULT_STORAGE_SPACE_QUOTA
would be easier to understand. Comments like @return the namespace and diskspace consumed
can also be edited to use storage space instead of diskspace. 
> * Add Javadocs to FsImageFormat.java on why storage type quota for FSImageFormat.java.
"We don't have quota by storage type record in legacy fsimages, which is handled in this FSImageFormat
class (used by legacy_oiv only). The current fsimage processing is done in the protobuf based
class FSImageFormatProtobuf, which is updated with typeCounts by HDFS-7723."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message