hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7764) DirectoryScanner should cancel the future tasks when #compileReport throws exception
Date Thu, 12 Feb 2015 21:59:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319069#comment-14319069
] 

Colin Patrick McCabe commented on HDFS-7764:
--------------------------------------------

Can you explain why we would want to cancel the other pending tasks?

It seems like having a problem generating a report for one volume should not impact generating
reports for the other volumes.

Did you see this code throw an exception in production?

> DirectoryScanner should cancel the future tasks when #compileReport throws exception
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-7764
>                 URL: https://issues.apache.org/jira/browse/HDFS-7764
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.7.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-7764.patch
>
>
> If there is an exception while preparing the ScanInfo for the blocks in the directory,
DirectoryScanner is immediately throwing exception and coming out of the current scan cycle.
It would be good if he can signal #cancel() to the other pending tasks .
> DirectoryScanner.java
> {code}
>     for (Entry<Integer, Future<ScanInfoPerBlockPool>> report :
>         compilersInProgress.entrySet()) {
>       try {
>         dirReports[report.getKey()] = report.getValue().get();
>       } catch (Exception ex) {
>         LOG.error("Error compiling report", ex);
>         // Propagate ex to DataBlockScanner to deal with
>         throw new RuntimeException(ex);
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message