hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7754) Fix findbugs warning produced by HDFS-7710
Date Mon, 09 Feb 2015 21:23:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312909#comment-14312909
] 

Xiaoyu Yao commented on HDFS-7754:
----------------------------------

IS2_INCONSISTENT_SYNC detector is strictly based on the ratio of locked vs unlocked access
of the class. HDFS-7710 removed one unused unlocked method, which changes the ratio (happen
to be the same as the count) of locked vs unlocked from 3: 3 to 3: 2.  

I agree with [~wheat9] on the importance of tracking additional synchronization to avoid unexpected
performance hit in future changes. However, this can be done with better tools for class like
BackupImage. IS2_INCONSISTENT_SYNC's has false alarm issue as described in its doc. It has
a limited support of exclusion rule, which only allows to ignore checking lock for a member
variable rather than whitelist/blacklist of locked/unlocked methods. Unfortunately, that is
what is supported findbugs 3.0. Based on that, I think [~ajisakaa]'s proposed fix is reasonable.
Please feel free to share your thoughts on a better fix. 

> Fix findbugs warning produced by HDFS-7710
> ------------------------------------------
>
>                 Key: HDFS-7754
>                 URL: https://issues.apache.org/jira/browse/HDFS-7754
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>         Attachments: HDFS-7710-001.patch
>
>
> There is a findbugs warning produced by HDFS-7710.
> https://builds.apache.org/job/PreCommit-HDFS-Build/9493//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message