hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7754) Fix findbugs warning produced by HDFS-7710
Date Mon, 09 Feb 2015 06:53:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14311869#comment-14311869
] 

Xiaoyu Yao commented on HDFS-7754:
----------------------------------

Thanks [~ajisakaa] and [~rakeshr] for working on this findbugs issue. 

Based on the description of IS2_INCONSISTENT_SYNC detector: "For example, the detector cannot
statically detect all situations in which a lock is held.  Also, even when the detector is
accurate in distinguishing locked vs. unlocked accesses, the code in question may still be
correct."
I agree with [~ajisakaa]'s fix to exclude IS2_INCONSISTENT_SYNC check for BackupImage.java
because it has carefully unsynchronized design. This will also avoid fixing the same problem
again in the future if we need to add more synchronized methods or remove some unsynchronized
methods for this class.

+1 (non-binding) for the fix. 

> Fix findbugs warning produced by HDFS-7710
> ------------------------------------------
>
>                 Key: HDFS-7754
>                 URL: https://issues.apache.org/jira/browse/HDFS-7754
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>         Attachments: HDFS-7710-001.patch
>
>
> There is a findbugs warning produced by HDFS-7710.
> https://builds.apache.org/job/PreCommit-HDFS-Build/9493//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message