hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7738) Add more negative tests for truncate
Date Fri, 06 Feb 2015 07:38:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308779#comment-14308779
] 

Konstantin Shvachko commented on HDFS-7738:
-------------------------------------------

# {{RecoverLeaseOp}} should be static
# Unused import Assert in {{TestSafeMode}}
# It seems that all test cases of {{testMultipleTruncate()}} are already covered in {{testBasicTruncate()}},
and in deterministic way. I would remove it. Unless random truncates increase your confidence.
# {{TestHAAppend}} changes look like a complete refactoring of the test. It is not necessary,
but would've been fine with me if it was not failing. Ran it several times, failed every time.
It would be OK to move it to another jira if you wish. I did not expect so many changes.

> Add more negative tests for truncate
> ------------------------------------
>
>                 Key: HDFS-7738
>                 URL: https://issues.apache.org/jira/browse/HDFS-7738
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: h7738_20150204.patch, h7738_20150205.patch, h7738_20150205b.patch
>
>
> The following are negative test cases for truncate.
> - new length > old length
> - truncating a directory
> - truncating a non-existing file
> - truncating a file without write permission
> - truncating a file opened for append
> - truncating a file in safemode



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message