hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7738) Add more negative tests for truncate
Date Fri, 06 Feb 2015 00:17:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308317#comment-14308317
] 

Tsz Wo Nicholas Sze commented on HDFS-7738:
-------------------------------------------

h7738_20150205.patch:
- adds RecoverLeaseOp;
- uses assertEquals as suggested
- changes DFSTestUtil.getFileSystemAs to not throwing InterruptedException
- moves safemode test to TestSafeMode
- adds truncate tests with HA

Konstantin, thanks for the review.  I incorporated all your comments except #3 since I like
to reuse the variable names.  Logically, they are separated test cases.

For the HA test, it cannot truncate for 5 times unless truncating at block boundaries since
the file is not ready (it is under recovery.)

> Add more negative tests for truncate
> ------------------------------------
>
>                 Key: HDFS-7738
>                 URL: https://issues.apache.org/jira/browse/HDFS-7738
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: h7738_20150204.patch, h7738_20150205.patch
>
>
> The following are negative test cases for truncate.
> - new length > old length
> - truncating a directory
> - truncating a non-existing file
> - truncating a file without write permission
> - truncating a file opened for append
> - truncating a file in safemode



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message