hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7720) Quota by Storage Type API, tools and ClientNameNode Protocol changes
Date Fri, 06 Feb 2015 01:49:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308439#comment-14308439

Xiaoyu Yao commented on HDFS-7720:

Thanks [~arpitagarwal] for the review. 

bq. 1 Do we need the new exception type? Are there any disadvantages to reusing the existing
QuotaExceededException? We can add a new constructor with storage type and overload toString
if type is non-null.

The new exception is added following the existing QuotaExceededException hierarchy. If the
multiple constructor approach is preferred, I could refactor it.

bq. 2 This patch should throw an exception in FSNameSystem#setQuota if storageType is non-null.
Do you mean NameNodeRpcServer#setQuota? The {code}FSNameSystem#setQuota{code} is handled in
HDFS-7223.  Yes. I can add that to avoid unexpected caller before HDFS-7223 is in.

> Quota by Storage Type API, tools and ClientNameNode Protocol changes
> --------------------------------------------------------------------
>                 Key: HDFS-7720
>                 URL: https://issues.apache.org/jira/browse/HDFS-7720
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Xiaoyu Yao
>            Assignee: Xiaoyu Yao
>         Attachments: HDFS-7720.0.patch, HDFS-7720.1.patch, HDFS-7720.2.patch
> Split the patch into small ones based on the feedback. This one covers the HDFS API changes,
tool changes and ClientNameNode protocol changes. 

This message was sent by Atlassian JIRA

View raw message