hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arun Suresh (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-7718) DFSClient objects created by AbstractFileSystem objects created by FileContext are not closed and results in thread leakage
Date Mon, 02 Feb 2015 22:16:35 GMT

     [ https://issues.apache.org/jira/browse/HDFS-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Arun Suresh updated HDFS-7718:
------------------------------
    Attachment: HDFS-7718.2.patch

thanks for the review [~cmccabe],

Updating patch with your suggestions :

bq. Should we be comparing the URIs as strings instead? I'm not that familiar with URI#equals,
what features of it make it the right thing here?
Hmmm.. We need to vefity that the String URI is actually a proper URI for which I create a
URI object in anycase. Which is why I decided to use it as the key itself.
I checked the {{URI#equals()}} method. looks like it does a good job of comparing URIs. I've
added a few tests to verify it as well 

> DFSClient objects created by AbstractFileSystem objects created by FileContext are not
closed and results in thread leakage
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-7718
>                 URL: https://issues.apache.org/jira/browse/HDFS-7718
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: HDFS-7718.1.patch, HDFS-7718.2.patch
>
>
> Currently, the {{FileContext}} class used by clients such as (for eg. {{YARNRunner}})
creates a new {{AbstractFilesystem}} object on initialization.. which creates a new {{DFSClient}}
object.. which in turn creates a KeyProvider object.. If Encryption is turned on, and https
is turned on, the keyprovider implementation (the {{KMSClientProvider}}) will create a {{ReloadingX509TrustManager}}
thread per instance... which are never killed and can lead to a thread leak



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message