hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7713) Improve the HDFS Web UI browser to allow creating dirs
Date Mon, 23 Feb 2015 23:50:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334104#comment-14334104
] 

Haohui Mai commented on HDFS-7713:
----------------------------------

{code}
+        <div class="dirCommands" id="dirCommands">
+          <button type="button" class="btn btn-primary" data-toggle="modal"
+            data-target="#create-directory">Create Directory
+          </button>
+        </div>
{code}

It is unnecessary to define the class and the id. It might also make sense to stick with the
current look and feel (i.e., using {{btn-default}} instead of {{btn-primary}}). It might also
make sense to replace it with a icon as well.

{code}
-          var path = $(this).attr('inode-path');
+          var path = $(this).closest('tr').attr('inode-path');
{code}

Doesn't seem necessary.

{code}
+          crossDomain: true
{code}

As {{MKDIR}} is only a metadata operation, there should be no need for allowing the request
to cross origin.

> Improve the HDFS Web UI browser to allow creating dirs
> ------------------------------------------------------
>
>                 Key: HDFS-7713
>                 URL: https://issues.apache.org/jira/browse/HDFS-7713
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: HDFS-7713.01.patch, HDFS-7713.02.patch, HDFS-7713.03.patch, HDFS-7713.04.patch
>
>
> This sub-task JIRA is for improving the NN HTML5 UI to allow the user to create directories.
It uses WebHDFS and adds to the great work done in HDFS-6252



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message