hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7698) Fix locking on HDFS read statistics and add a method for clearing them.
Date Thu, 05 Feb 2015 08:03:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306803#comment-14306803
] 

Yi Liu commented on HDFS-7698:
------------------------------

Thanks Colin for the patch.
It looks good to me, just few comments. +1 after addressing.
# In DFSInputStream#tryReadZeroCopy, we should also hold the {{infoLock}} for {{readStatistics}}.
# For HdfsDataInputStream#getAllBlocks, we could remove the {{synchronized}} too.

> Fix locking on HDFS read statistics and add a method for clearing them.
> -----------------------------------------------------------------------
>
>                 Key: HDFS-7698
>                 URL: https://issues.apache.org/jira/browse/HDFS-7698
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-7698.002.patch
>
>
> Fix locking on HDFS read statistics and add a method for clearing them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message