hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7647) DatanodeManager.sortLocatedBlocks() sorts DatanodeInfos but not StorageIDs
Date Mon, 09 Feb 2015 19:48:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312736#comment-14312736
] 

Arpit Agarwal commented on HDFS-7647:
-------------------------------------

Hi [~milandesai], thank you again for your patience with the patch revisions!

The latest version looks good. Just a nitpick, and I do feel bad having you upload another
patch revision -
- I think {{DatanodeInfoWithStorage#equals}} and {{#hashCode}} are unnecessary since they
just forward to the superclass versions with no additional work. I removed them and verified
the test case still passes. Do you think we could eliminate them?

> DatanodeManager.sortLocatedBlocks() sorts DatanodeInfos but not StorageIDs
> --------------------------------------------------------------------------
>
>                 Key: HDFS-7647
>                 URL: https://issues.apache.org/jira/browse/HDFS-7647
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Milan Desai
>            Assignee: Milan Desai
>         Attachments: HDFS-7647-2.patch, HDFS-7647-3.patch, HDFS-7647-4.patch, HDFS-7647-5.patch,
HDFS-7647-6.patch, HDFS-7647-7.patch, HDFS-7647.patch
>
>
> DatanodeManager.sortLocatedBlocks() sorts the array of DatanodeInfos inside each LocatedBlock,
but does not touch the array of StorageIDs and StorageTypes. As a result, the DatanodeInfos
and StorageIDs/StorageTypes are mismatched. The method is called by FSNamesystem.getBlockLocations(),
so the client will not know which StorageID/Type corresponds to which DatanodeInfo.	



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message