hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-7495) Remove updatePosition argument from DFSInputStream#getBlockAt()
Date Thu, 26 Feb 2015 14:21:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338427#comment-14338427
] 

Hudson commented on HDFS-7495:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk #2048 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2048/])
HDFS-7495. Remove updatePosition argument from DFSInputStream#getBlockAt() (cmccabe) (cmccabe:
rev caa42adf208bfb5625d1b3ef665fbf334ffcccd9)
* hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
* hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Remove updatePosition argument from DFSInputStream#getBlockAt()
> ---------------------------------------------------------------
>
>                 Key: HDFS-7495
>                 URL: https://issues.apache.org/jira/browse/HDFS-7495
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Ted Yu
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: HDFS-7495.002.patch, hdfs-7495-001.patch
>
>
> There're two locks: one on DFSInputStream.this , one on DFSInputStream.infoLock
> Normally lock is obtained on infoLock, then on DFSInputStream.infoLock
> However, such order is not observed in DFSInputStream#getBlockAt() :
> {code}
>     synchronized(infoLock) {
> ...
>       if (updatePosition) {
>         // synchronized not strictly needed, since we only get here
>         // from synchronized caller methods
>         synchronized(this) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message